Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken dependency js-sequence-diagrams #41

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

SISheogorath
Copy link
Contributor

A few days ago the dependency was removed from npm. this causes various
setups to fail and blocks deployments and development.

This patch should fix the dependency and allow CodiMD to move forward.

Fixes #39

A few days ago the dependency was removed from npm. this causes various
setups to fail and blocks deployments and development.

This patch should fix the dependency and allow CodiMD to move forward.

Signed-off-by: Sheogorath <[email protected]>
@SISheogorath SISheogorath added the type: bug Something isn't working label Apr 9, 2019
@SISheogorath SISheogorath added this to the Release 1.4.0 milestone Apr 9, 2019
@SISheogorath SISheogorath requested a review from ccoenen April 9, 2019 22:20
@SISheogorath
Copy link
Contributor Author

Just verified in a container that it works.

Also opened a PR to get our changes upstream: bramp/js-sequence-diagrams#215

@SISheogorath SISheogorath merged commit f541c00 into hedgedoc:master Apr 10, 2019
@SISheogorath SISheogorath deleted the js-diagram-v2 branch April 10, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] has been unpublished and replaced by a security holding package
1 participant